Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update setup-protoc from v1 to v3 #1175

Merged
merged 6 commits into from
Apr 26, 2024

Conversation

charliecruzan-stripe
Copy link
Contributor

@charliecruzan-stripe charliecruzan-stripe commented Apr 25, 2024

Reviewers

r? @
cc @stripe/developer-products

Summary

We were using an old version of arduino/setup-protoc that didnt support ARM architecture for macos, which I suppose the macos-latest runners just started using, so this began failing. After upgrading, we hit another error related to diffing, and golangci/golangci-lint#3087 pointed me to installing diffutils which worked

@charliecruzan-stripe charliecruzan-stripe requested a review from a team as a code owner April 25, 2024 23:21
@charliecruzan-stripe charliecruzan-stripe merged commit 845273f into master Apr 26, 2024
7 checks passed
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan/updatesetupprotoc branch April 26, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants