Build all platforms in CI #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
force-pushed
the
ob-ci-compile-all-platforms
branch
2 times, most recently
from
2c00bbb
to
892f7c3
Compare
ob-stripe
force-pushed
the
ob-ci-compile-all-platforms
branch
from
892f7c3
to
a325290
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @joek-stripe
cc @stripe/dev-platform
Summary
This isn't the first time we merge code, only to discover that the code fails to compile for a specific platform when we try to release a new version.
This PR ensures that we build the CLI for all supported platforms in CI, so we can catch these issues earlier.