Telemetry: command path #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomer-stripe
approved these changes
Oct 15, 2019
ob-stripe
force-pushed
the
ob-telemetry
branch
from
a377478
to
2f06f28
Compare
|
@tomer-stripe Can you take another look? I've changed the way it works to only send the command name, but no arguments or flags. ptal @tomer-stripe |
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @tomer-stripe @brandur-stripe
cc @stripe/dev-platform
Summary
Add very basic telemetry: send the command path (e.g.
charges create,listen, etc.) in API requests, in a newStripe-CLI-Telemetryheader.The header contains a JSON string, so we can easily add more information in there.
Users can opt out of telemetry by setting
STRIPE_CLI_TELEMETRY_OPTOUTto1ortrue.