stripe login: poll for api key #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your build status at https://cibot.corp.stripe.com/builds/pull/git@github.com/stripe/stripe-cli/4. |
ob-stripe
suggested changes
Jun 27, 2019
There was a problem hiding this comment.
Some comments, and I think we need a test for this. Once you make the interval and max attempts values arguments, we can write a test with a short interval and a low max attempts.
You can take a look at e.g. stripeauth/client_test.go for an example of how to mock a server to test a client.
jmuia-stripe
force-pushed
the
jmuia.login-poll
branch
from
b550495
to
cf3a7d8
Compare
| client := stripeauth.NewHTTPClient("") | ||
|
|
||
| var count = 0 | ||
| for count < maxAttempts { |
There was a problem hiding this comment.
Should there be a test to verify the polling functionality works right?
jmuia-stripe
force-pushed
the
jmuia.login-poll
branch
from
cf3a7d8
to
5709422
Compare
|
ptal @ob-stripe |
|
Sorry for the delay! This looks great, especially the tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @ob-stripe @brandonl-stripe
cc @tomer-stripe
Summary
Implements the function to poll for the API key.
A counter for poll attempts is an easier model to implement than a polling timeout.
NB. in a follow-up we can extract the http client rather than simply making the current one public.