Disable update checking in stripe listen command #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pepin-stripe
approved these changes
Nov 6, 2020
There was a problem hiding this comment.
hey @ritikbhatia thanks for the PR! Looks great, feel free to merge and it will get into the next release!
|
Hi @pepin-stripe! Thanks for approving the PR! I cannot merge the PR since I do not have write access to the repository. Could you (or anyone in the Stripe team with write access to the repo) merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @richardm-stripe @tomer-stripe
cc @stripe/developer-products
Summary
This pull request is a potential solution to PR #496
This PR adds the
--skip-update/-sflag to allow the user to skip checking for update. This will help improve the speed by avoiding the overhead of checking for new updates.Example commands for usage of this flag:
stripe listen --skip-updatestripe listen -s