Refactor logs tail command with channel and visitors #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepin-stripe
approved these changes
May 7, 2021
az777777
pushed a commit
to az777777/stripe-cli
that referenced
this pull request
Jun 22, 2021
* Refactor logs tail command * cleanup * renaming * Renaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @pepin-stripe
cc @stripe/developer-products
Summary
This decouples user IO and the receiving of logs.
Taileris concerned with sending data on a channel. The data is either a log, an error, a warning, or a connection state.Tailer, receives these different data types and processes them using a visitor object.This pattern enables
Tailerto be used by any class that wants to do something with logs, for example a gRPC service that wants to stream logs, errors, and connection state to a gRPC client. All the class has to do is read from the channel and provide its own visitor object.This pattern might also work well for #574. This is quite boilerplate heavy, so I am open to other solutions as well.