Tweak OpenAPI spec embedding (again) #67
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @tomer-stripe @brandur-stripe
cc @stripe/dev-platform
Summary
Sorry for all the back and forth... Hopefully this will work.
This is basically a revert of #58, except that:
vfsgen
instead ofignore
.ignore
is a special value which causes the package to be completely ignored and thus the dependencies were omitted fromgo.mod
. By setting it to a different value (vfsgen
, to be consistent with the file name, but it could really be anything), the dependencies are properly included.go generate ./...
producing different results. This ensures that the generatedfs_vfsdata.go
file will only change when the file contents are actually updated.