New login configuration flow #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your build status at https://cibot.corp.stripe.com/builds/pull/git@github.com/stripe/stripe-cli/7. |
brandonl-stripe
force-pushed
the
cli-login
branch
from
011e9d3
to
3f8b647
Compare
ob-stripe
reviewed
Jul 5, 2019
There was a problem hiding this comment.
ptal @brandonl-stripe @jmuia-stripe
Looks great overall! One comment about possibly avoid a new dependency, but it's fine if you think the new library is better than the one we already have. Just let me know.
brandonl-stripe
force-pushed
the
cli-login
branch
3 times, most recently
from
a776a19
to
b84b1f1
Compare
- go formatted cmd directory & make profile public - remove configure command moved under stripe auth --interactive - Create login command - Break cli configuration into own file (config.go) - test files with @jmuia-stripe
brandonl-stripe
force-pushed
the
cli-login
branch
from
b84b1f1
to
b0e4fc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
with @jmuia-stripe
Reviewers
r? @ob-stripe @
cc @stripe/dev-platform @jmuia-stripe