Show friendly message when API key is expired

[bernerd-stripe]

Reviewers

r? @stripe/developer-products
cc @remi-stripe

Summary

The restricted API keys created by the CLI expire after 90 days, but any restricted API key can also be forcibly expired by rolling. Previously, when invoking the CLI with an expired key we would render the entire error response body (and also returned a successful exit code):

$ stripe accounts retrieve
{
  "error": {
    "code": "api_key_expired",
    "doc_url": "https://stripe.com/docs/error-codes/api-key-expired",
    "message": "Expired API Key provided: rk_test_*********************************************************************************************aaaaaa",
    "type": "invalid_request_error"
  }
}
$ echo $?
0

This updates the CLI to handle the api_key_expired error and show a tailored error message:

$ stripe accounts retrieve
The API key provided has expired. Obtain a new key from the Dashboard or run `stripe login` and try again.
$ echo $?
1

[bernerd-stripe]

This does make unauthorized responses return an error even if errOnStatus is false, as it is for all resource commands in the CLI today. I think this is appropriate general behavior, since 401s are not otherwise recoverable?

[pepin-stripe]

Thanks, that looks great!

The one question I have (non blocking) is, are there other places where we might face an expired api error (stripe listen, etc) where we could leverage that?

[bernerd-stripe]

The one question I have (non blocking) is, are there other places where we might face an expired api error (stripe listen, etc) where we could leverage that?

It looks like yes, but would require some more thought because stripe listen uses the CLI's client package directly, so it doesn't share any error processing logic with the requests package.