fix: deadlock when resetting connection #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acomley-stripe
commented
Dec 7, 2021
pepin-stripe
reviewed
Dec 8, 2021
pepin-stripe
reviewed
Dec 8, 2021
pepin-stripe
approved these changes
Dec 8, 2021
| case <-c.stopWritePump: | ||
| c.cfg.Log.WithFields(log.Fields{ | ||
| "prefix": "websocket.Client.writePump", | ||
| }).Debug("Failed to send ping; connection is resetting") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @pepin-stripe
cc @stripe/developer-products
Summary
When the timer triggers to reset the connection, a deadlock can occur if the ping write fails during that period.