Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run stripe login with project name flag if config not found #902

Merged
merged 3 commits into from
Jul 5, 2022

Conversation

joyluu-stripe
Copy link
Contributor

@joyluu-stripe joyluu-stripe commented Jun 27, 2022

Reviewers

r? @etsai-stripe
cc @stripe/developer-products

Summary

When running command with the --project-name=... flag, the CLI would run stripe login... like so:

Screen Shot 2022-06-24 at 11 13 42 AM

Changes this message so that it instead asks the user to run stripe login --project-name...:

Screen Shot 2022-06-27 at 12 35 32 PM

The same message should show up when the shorthand flag -p is used, and when multiple flags are used in the command:

Screen Shot 2022-06-29 at 6 10 53 PM

Screen Shot 2022-06-29 at 6 10 36 PM

…f command is run with flag and no config present
pkg/cmd/root.go Outdated Show resolved Hide resolved
@joyluu-stripe joyluu-stripe marked this pull request as ready for review June 27, 2022 19:36
@joyluu-stripe joyluu-stripe merged commit 77c7c03 into master Jul 5, 2022
@tomer-stripe tomer-stripe deleted the joyluu-suggest-login-with-flag branch September 6, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants