Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move operations with path "/v1/test_helpers/*" to test_helpers namespace #965

Merged
merged 5 commits into from
Sep 6, 2022

Conversation

etsai-stripe
Copy link
Contributor

@etsai-stripe etsai-stripe commented Sep 6, 2022

Reviewers

r? @tomer-stripe @vcheung-stripe
cc @stripe/developer-products

Summary

all commands under test_helpers namespace

$ stripe test_helpers --help
Usage:
  stripe test_helpers <resource> <operation> [parameters...]

Available Resources:
  customers
  issuing
  refunds
  terminal
  test_clocks
  treasury

command added to test_helpers namespace invokes expected /v1 path

$ stripe test_helpers treasury received_credits create
{
  "error": {
    "message": "Unrecognized request URL (POST: /v1/test_helpers/treasury/received_credits). Please see https://stripe.com/docs or we can help at https://support.stripe.com/. (Hint: Have you onboarded to Treasury? You can learn more about the steps needed at https://stripe.com/docs/treasury/access)",
    "type": "invalid_request_error"
  }
}

test_helpers added to original command as sub-resource, invokes expected /v1 path

$ stripe treasury received_credits test_helpers create
{
  "error": {
    "message": "Unrecognized request URL (POST: /v1/test_helpers/treasury/received_credits). Please see https://stripe.com/docs or we can help at https://support.stripe.com/. (Hint: Have you onboarded to Treasury? You can learn more about the steps needed at https://stripe.com/docs/treasury/access)",
    "type": "invalid_request_error"
  }
}

test_helpers displayed in the usage of the original command

$ stripe treasury received_credits
Usage:
  stripe treasury received_credits <operation> [parameters...]

Available Operations:
  list
  retrieve
  test_helpers

@etsai-stripe etsai-stripe requested a review from a team as a code owner September 6, 2022 16:30
Copy link
Collaborator

@vcheung-stripe vcheung-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etsai-stripe etsai-stripe merged commit 05ecf95 into master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants