Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix theming update issue #102

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Fix theming update issue #102

merged 2 commits into from
Dec 5, 2023

Conversation

jorgea-stripe
Copy link
Collaborator

@jorgea-stripe jorgea-stripe commented Dec 5, 2023 •
edited
Loading

There is a race condition on how FurEver calls update. It should do so on changes to the theme, not to color.

bkirk-stripe
bkirk-stripe approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@bkirk-stripe bkirk-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on furever locally, things are looking good

@jorgea-stripe jorgea-stripe merged commit 00effe0 into master Dec 5, 2023
1 check passed
@jorgea-stripe jorgea-stripe deleted the jorgea/fix-theming branch December 5, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkirk-stripe bkirk-stripe bkirk-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jorgea-stripe @bkirk-stripe