Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SD prefilling #106

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Remove SD prefilling #106

merged 5 commits into from
Mar 26, 2024

Conversation

streeter-stripe
Copy link
Contributor

Post Odyssey, the statement descriptor is prefilled automatically for anything. So no need to prefill ourselves, as it might be wrong!

Post Odyssey, the statement descriptor is prefilled automatically for
anything. So no need to prefill ourselves, as it might be wrong!
? {
settings: {
card_payments: {
statement_descriptor_prefix: 'FurEver',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically, this shouldn't be what we use for a connected account - this is the name of the platform, but not the name of the connected account.

@@ -286,18 +286,6 @@ app.post('/create-account', userRequired, async (req, res) => {
: {}),
},
business_type: businessType,
...(shouldPrefill
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this to verify it isn't actually required for our prefill option to get charges and transfers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

Copy link
Collaborator

@jorgea-stripe jorgea-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@streeter-stripe streeter-stripe merged commit 657507b into master Mar 26, 2024
1 check passed
@streeter-stripe streeter-stripe deleted the streeter-remove-sd branch March 26, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants