opt-in to baas features #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekaliski-stripe
force-pushed
the
stevekaliski-baas-opt-in
branch
2 times, most recently
from
0255fa4
to
fc0bc1a
Compare
| }} | ||
| onSuccess={async () => { | ||
| await navigate('/onboarding'); | ||
| navigate(0); |
There was a problem hiding this comment.
This "works" -- the reason for the navigate + refresh is that when i navigate to /onboarding, the updated capability request isn't reflected yet, so when the user submits, they haven't attested to the issuing/treasury ToS. but with the refresh, it forces a reload (and delay?) so it gets picked up.
stevekaliski-stripe
force-pushed
the
stevekaliski-baas-opt-in
branch
from
fc0bc1a
to
3e62f5c
Compare
stevekaliski-stripe
force-pushed
the
stevekaliski-baas-opt-in
branch
from
3e62f5c
to
b0e7987
Compare
jorgea-stripe
approved these changes
Apr 22, 2024
| capabilities, | ||
| onSuccess, | ||
| }: RequestCapabilitiesProps) => { | ||
| const {mutate} = useRequestCapabilities(capabilities); |
There was a problem hiding this comment.
nit: The loading and error state isn't used here (we should display a spinner/loading state and render an error if one occurred)
| }, | ||
| }} | ||
| onSuccess={async () => { | ||
| await navigate('/onboarding'); |
There was a problem hiding this comment.
Suggested change
| await navigate('/onboarding'); | |
| // After requesting the capabilities successfully, we force a full page reload | |
| await navigate('/onboarding'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the flow to be opt-in to financial features. When the user is in a supportable connect config, render the
Financetab. If the user does not have the required capabilities yet, display a welcome screen the prompts the user to "enable". Clicking requests the capabilities, routes back to /onboarding, and depending on the capability requested, will create an FA.baas-2.mp4