Automatically convert Unix timestamps to DateTimes #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
reviewed
Oct 2, 2018
There was a problem hiding this comment.
O
M
G
:micdrop:
Joke aside: This looks amazing and so much easier to not mess up or forget.
Is there any risk that this changes some default behaviour with DateTime? I don't know anything about that type and was curious if people could have configured things like default timezone and such for us to convert properly and now that the conversion is hidden in the internals maybe they can't? Likely not a realistic thought though
| @@ -10,7 +10,7 @@ public static void Map(object value, Action<string> updateId, Action<T> updateOb | |||
| { | |||
| if (value is JObject) | |||
| { | |||
| T item = ((JToken)value).ToObject<T>(); | |||
| T item = Mapper<T>.MapFromJson(value.ToString()); | |||
There was a problem hiding this comment.
Can you document this line explicitly as to what it does, why the change and maybe a TODO to figure out in the future how to avoid the parsed => toString => parsed?
ob-stripe
force-pushed
the
ob-auto-convert-datetime
branch
2 times, most recently
from
d82c63c
to
4b8bdfb
Compare
ob-stripe
force-pushed
the
ob-auto-convert-datetime
branch
from
4b8bdfb
to
54dee88
Compare
remi-stripe
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @remi-stripe
cc @stripe/api-libraries