Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add confirm property to SetupIntentCreateOptions #1696

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Add confirm property to SetupIntentCreateOptions #1696

merged 1 commit into from
Jul 10, 2019

Conversation

richardlawley
Copy link
Contributor

https://stripe.com/docs/api/setup_intents/create lists a confirm property which was not present in the SetupIntentCreateOptions.

@remi-stripe
Copy link
Contributor

@richardlawley Thanks for opening a PR for this. Would you mind adding support for return_url too? https://stripe.com/docs/api/setup_intents/create#create_setup_intent-return_url

@richardlawley
Copy link
Contributor Author

@remi-stripe Done (squashed into one commit).

remi-stripe
remi-stripe approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for making the changes quickly!

@remi-stripe remi-stripe merged commit 5d27113 into stripe:master Jul 10, 2019
@remi-stripe
Copy link
Contributor

This was released at 27.10.0. Thanks again for making the changes @richardlawley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@richardlawley richardlawley

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@richardlawley @remi-stripe @stripe-ci