Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Balance History to /v1/balance_transactions #1724

Merged
merged 1 commit into from Jul 31, 2019
Merged

Move Balance History to /v1/balance_transactions #1724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion appveyor.yml
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@ environment:
COVERALLS_REPO_TOKEN:
secure: T0PmP8uyzCseacBCDRBlti2y9Tz5DL6fknea0MKWvbPYrzADmLY2/5kOTfYIsPUk
# If you bump this, don't forget to bump `MinimumMockVersion` in `StripeMockFixture.cs` as well.
STRIPE_MOCK_VERSION: 0.60.0
STRIPE_MOCK_VERSION: 0.63.0

deploy:
- provider: NuGet
Expand Down
2 changes: 1 addition & 1 deletion src/Stripe.net/Services/BalanceTransactions/BalanceTransactionService.cs
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@ public BalanceTransactionService(IStripeClient client)
{
}

public override string BasePath => "/v1/balance/history";
public override string BasePath => "/v1/balance_transactions";

[Obsolete("Use BaseOptions.AddExpand instead.")]
public bool ExpandSource { get; set; }
Expand Down
8 changes: 4 additions & 4 deletions src/StripeTests/Services/BalanceTransactions/BalanceTransactionServiceTest.cs
View file
Open in desktop
Expand Up @@ -31,7 +31,7 @@ public class BalanceTransactionServiceTest : BaseStripeTest
public void Get()
{
var balanceTransaction = this.service.Get(BalanceTransactionId);
this.AssertRequest(HttpMethod.Get, "/v1/balance/history/txn_123");
this.AssertRequest(HttpMethod.Get, "/v1/balance_transactions/txn_123");
Assert.NotNull(balanceTransaction);
Assert.Equal("balance_transaction", balanceTransaction.Object);
}
Expand All @@ -40,7 +40,7 @@ public void Get()
public async Task GetAsync()
{
var balanceTransaction = await this.service.GetAsync(BalanceTransactionId);
this.AssertRequest(HttpMethod.Get, "/v1/balance/history/txn_123");
this.AssertRequest(HttpMethod.Get, "/v1/balance_transactions/txn_123");
Assert.NotNull(balanceTransaction);
Assert.Equal("balance_transaction", balanceTransaction.Object);
}
Expand All @@ -49,7 +49,7 @@ public async Task GetAsync()
public void List()
{
var balanceTransactions = this.service.List(this.listOptions);
this.AssertRequest(HttpMethod.Get, "/v1/balance/history");
this.AssertRequest(HttpMethod.Get, "/v1/balance_transactions");
Assert.NotNull(balanceTransactions);
Assert.Equal("list", balanceTransactions.Object);
Assert.Single(balanceTransactions.Data);
Expand All @@ -60,7 +60,7 @@ public void List()
public async Task ListAsync()
{
var balanceTransactions = await this.service.ListAsync(this.listOptions);
this.AssertRequest(HttpMethod.Get, "/v1/balance/history");
this.AssertRequest(HttpMethod.Get, "/v1/balance_transactions");
Assert.NotNull(balanceTransactions);
Assert.Equal("list", balanceTransactions.Object);
Assert.Single(balanceTransactions.Data);
Expand Down
2 changes: 1 addition & 1 deletion src/StripeTests/StripeMockFixture.cs
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@ public class StripeMockFixture : IDisposable
/// <remarks>
/// If you bump this, don't forget to bump `STRIPE_MOCK_VERSION` in `appveyor.yml` as well.
/// </remarks>
private const string MockMinimumVersion = "0.60.0";
private const string MockMinimumVersion = "0.63.0";

private readonly string port;

Expand Down