Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing IHas* interfaces everywhere #1733

Merged
merged 5 commits into from Aug 8, 2019
Merged

Add missing IHas* interfaces everywhere #1733

merged 5 commits into from Aug 8, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries

This PR:

  • adds a wholesome test to check that Stripe entities and options classes that can implement a specific IHas* interface do inherit the interface
  • adds the interfaces to all options classes (previously they were only applied to entities classes)

brandur-stripe
brandur-stripe approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@brandur-stripe brandur-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome man. LGTM.

@ob-stripe
Copy link
Contributor Author

Thanks for the quick review!

@ob-stripe ob-stripe merged commit 29c3194 into master Aug 8, 2019
@ob-stripe ob-stripe deleted the ob-interfaces branch August 8, 2019 21:25
@ob-stripe
Copy link
Contributor Author

Released as 27.22.0.

pull bot pushed a commit to scope-demo/stripe-dotnet that referenced this pull request Aug 14, 2019
@ob-stripe @pull
Add missing IHas* interfaces everywhere (stripe#1733)
6f71ddb 
* Add new wholesome test to look for missing IHas* interfaces

* Add missing IHasId interface

* Add missing IHasObject interface

* Fix test

* Add missing IHasMetadata interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandur-stripe brandur-stripe brandur-stripe approved these changes

Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ob-stripe @brandur-stripe @stripe-ci @remi-stripe