Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET 5.0 target #2246

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Add .NET 5.0 target #2246

merged 1 commit into from
Dec 9, 2020

Conversation

ob-stripe
Copy link
Contributor

r? @richardm-stripe

.NET 5.0 was released today. Microsoft recommends that reusable libraries add it as a build target but still keep targeting .NET Standard 2.0 as well for backwards compatibility.

Copy link
Contributor

@richardm-stripe richardm-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ob-stripe
Copy link
Contributor Author

It looks like the 5.0 SDK included in Appveyor's "Visual Studio 2019 Preview" image is still the RC1 version and not the final version, so I'll wait until they update it to the final version before merging.

@ob-stripe ob-stripe force-pushed the ob-target-net5 branch 3 times, most recently from 2b8fe05 to 400d92b Compare November 11, 2020 18:12
@ob-stripe
Copy link
Contributor Author

Appveyor added .NET 5.0 to the Visual Studio 2019 image (cf. https://www.appveyor.com/updates/2020/11/14/).

I've also updated the RuntimeInformation code to properly report .NET 5 as ".NET 5.0.0" rather than ".NET Core 5.0.0". Like the initial code, the updated code is basically lifted straight from the BenchmarkDotnet project (https://github.com/dotnet/BenchmarkDotNet/blob/0de41c2864de41fef983e55790490f1b3364ccbf/src/BenchmarkDotNet/Portability/RuntimeInformation.cs)

ptal @richardm-stripe

@ob-stripe ob-stripe merged commit 17f80b6 into master Dec 9, 2020
@ob-stripe ob-stripe deleted the ob-target-net5 branch December 9, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants