Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Updates #2325

Merged
merged 3 commits into from
Jun 4, 2021
Merged

API Updates #2325

merged 3 commits into from
Jun 4, 2021

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Jun 3, 2021 •
edited

Codegen for openapi 1ad8d09.
r? @richardm-stripe
cc @stripe/api-libraries

Changelog

  • Add support for new TaxCode API.
  • Add support for TaxCode on Product API, and PriceProductDataOptions
  • Add support for Tax on Customer API
  • Add support for AutomaticTax on Checkout Session API, Invoice API, SubscriptionScheduleDefaultSettings API, SubscriptionSchedulePhase API, SubscriptionCreateOptions, and SubscriptionUpdateOptions
  • Add support for TaxBehavior on Price API, Checkout SessionLineItemPriceDataOptions, InvoiceSubscriptionItemPriceDataOptions, SubscriptionSchedulePhaseAddInvoiceItemPriceDataOptions, SubscriptionSchedulePhaseItemPriceDataOptions, and SubscriptionAddInvoiceItemPriceDataOptions
  • Add support for TaxType on TaxRate API
  • Add support for CustomerUpdate on Checkout SessionCreateOptions

remi-stripe
remi-stripe reviewed Jun 4, 2021
View reviewed changes
src/Stripe.net/Services/Invoices/InvoiceLineItemAutomaticTaxOptions.cs
[JsonProperty("enabled")]
public bool? Enabled { get; set; }
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure what this change is about. Is it just to paginate line items on the upcoming invoice specifically?

remi-stripe
remi-stripe approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since I reviewed the whole PR and it matches what I expected from the review.

@richardm-stripe richardm-stripe merged commit c4b5ee5 into master Jun 4, 2021
@richardm-stripe richardm-stripe deleted the latest-codegen branch June 4, 2021 15:42
@Andrewangeta Andrewangeta mentioned this pull request Jul 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@richardm-stripe richardm-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@richardm-stripe @remi-stripe