Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Updates #2414

Merged
merged 1 commit into from Jan 19, 2022
Merged

API Updates #2414

merged 1 commit into from Jan 19, 2022

Conversation

dcr-stripe
Copy link
Contributor

Codegen for openapi 7734045.
r? @yejia-stripe
cc @stripe/api-libraries

Changelog

  • Add support for BacsDebit and Eps on PaymentIntentPaymentMethodOptionsOptions, PaymentIntentPaymentMethodOptionsOptions, PaymentIntentPaymentMethodOptionsOptions, and PaymentIntentPaymentMethodOptions
  • Add support for ImageUrlPng and ImageUrlSvg on PaymentIntentNextActionWechatPayDisplayQrCode

@stripe-ci stripe-ci assigned dcr-stripe and unassigned yejia-stripe Jan 19, 2022
@@ -16,5 +16,17 @@ public class PaymentIntentNextActionWechatPayDisplayQrCode : StripeEntity<Paymen
/// </summary>
[JsonProperty("image_data_url")]
public string ImageDataUrl { get; set; }

/// <summary>
/// The image_url_png string used to render QR code, can be used as &lt;img src="…" /&gt;.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the </> replacements easy to change? Or is this how they're supposed to be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! C# uses XML for its comments. Unfortunately we have to encode it otherwise the documentation interpreter will think they're part of the documentation tags and interpret it as such, rendering a broken document. We can see this elsewhere in the codebase: https://github.com/stripe/stripe-dotnet/search?q=%26lt%3B

@dcr-stripe dcr-stripe merged commit fc711f7 into master Jan 19, 2022
@dcr-stripe dcr-stripe deleted the latest-codegen branch January 19, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants