Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage using Coveralls #2569

Merged
merged 2 commits into from Aug 29, 2022
Merged

Add test coverage using Coveralls #2569

merged 2 commits into from Aug 29, 2022

Conversation

anniel-stripe
Copy link
Contributor

@anniel-stripe anniel-stripe commented Aug 26, 2022

Summary

r? @kamil-stripe
r? @pakrym-stripe

Add steps to collect test coverage and upload to coveralls in CI. Test coverage data will be published to https://coveralls.io/github/stripe/stripe-dotnet and displayed as a badge in the README.

@anniel-stripe anniel-stripe marked this pull request as ready for review August 26, 2022 21:23
Copy link
Contributor

@kamil-stripe kamil-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The badge shows "unknown" right now. Is that expected?

@anniel-stripe
Copy link
Contributor Author

The badge shows "unknown" right now. Is that expected?

Oh hmm that is not expected, let me look into this.

@anniel-stripe
Copy link
Contributor Author

I'm seeing this:
Screen Shot 2022-08-26 at 2 31 53 PM

Maybe it was a temporary thing?

@anniel-stripe anniel-stripe merged commit dd18901 into master Aug 29, 2022
@anniel-stripe anniel-stripe deleted the anniel-coveralls branch August 29, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants