Add support for GrabpayPayments as a capability on Account
#1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -274,7 +280,7 @@ type AccountCapabilitiesParams struct { | |||
| CartesBancairesPayments *AccountCapabilitiesCartesBancairesPaymentsParams `form:"cartes_bancaires_payments"` | |||
| EPSPayments *AccountCapabilitiesEPSPaymentsParams `form:"eps_payments"` | |||
| FPXPayments *AccountCapabilitiesFPXPaymentsParams `form:"fpx_payments"` | |||
| GiropayPayments *AccountCapabilitiesGiropayPaymentsParams `form:"giropay_payments"` | |||
| GrabpayPayments *AccountCapabilitiesGrabpayPaymentsParams `form:"grabpay_payments"` | |||
There was a problem hiding this comment.
This mistakenly removes Giropay I think.
Suggested change
| GrabpayPayments *AccountCapabilitiesGrabpayPaymentsParams `form:"grabpay_payments"` | |
| GiropayPayments *AccountCapabilitiesGiropayPaymentsParams `form:"giropay_payments"` | |
| GrabpayPayments *AccountCapabilitiesGrabpayPaymentsParams `form:"grabpay_payments"` |
There was a problem hiding this comment.
Oops, nice catch, PTAL
richardm-stripe
requested changes
Nov 20, 2020
remi-stripe
force-pushed
the
remi-capabilities-grabpay
branch
from
8e8f5f1
to
a5c77c9
Compare
richardm-stripe
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @richardm-stripe
cc @stripe/api-libraries