Codegen 10 more files #1264
Codegen 10 more files #1264
Conversation
richardm-stripe
force-pushed
the
richardm-more-codegen
branch
from
a05fe68
to
0c7aaac
Compare
| @@ -22,8 +30,8 @@ const ( | |||
| // For more details see https://stripe.com/docs/api/customers/create_customer_balance_transaction | |||
| type CustomerBalanceTransactionParams struct { | |||
| Params `form:"*"` | |||
| Customer *string `form:"-"` // Included in URL | |||
There was a problem hiding this comment.
That isn't in alphabetical anymore. Not the end of the world but is it something we can easily tweak?
There was a problem hiding this comment.
The convention now is embeds, path params, then normal params, and alphabetical within those categories. A saw the hoisting of path params in a couple files and thought it made sense even though we don't follow it consistently, but yes I can easily alphabetize the whole thing if we think that is better.
Maybe a newline between the path params and the remainder?
There was a problem hiding this comment.
I personally prefer everyone alphabetical. What's URL param and whats POST param shouldn't really matter to developers and it's easier for people's brain (and ours) to parse alphabetically. Not a blocker though.
terminal_location.go
Outdated
| Livemode bool `json:"livemode"` | ||
| Metadata map[string]string `json:"metadata"` | ||
| Object string `json:"object"` | ||
| Address *AccountAddress `json:"address"` |
There was a problem hiding this comment.
Is that one a breaking change?
There was a problem hiding this comment.
It's either a breaking change or a bugfix.
AccountAddressParams right now only has form annotatations and not json annotations, so I think right now it's pretty broken and these will not ever deserialize into anything but zero values.
| @@ -22,8 +30,8 @@ const ( | |||
| // For more details see https://stripe.com/docs/api/customers/create_customer_balance_transaction | |||
| type CustomerBalanceTransactionParams struct { | |||
| Params `form:"*"` | |||
| Customer *string `form:"-"` // Included in URL | |||
There was a problem hiding this comment.
I personally prefer everyone alphabetical. What's URL param and whats POST param shouldn't really matter to developers and it's easier for people's brain (and ours) to parse alphabetically. Not a blocker though.
r? @remi-stripe - removed the potential breaking change, this is ready for a real review
applepaydomain.goDomainNamefield to the ListParams.https://github.com/stripe/stripe-go/pull/1264/files#diff-cbfd212f7ddc855ea5f8d193fa576a280cc362cd76c23e619917129eaffbbdf3R18
Objectfieldapplication.goObjectfieldcustomerbalancetransaction.goCustomerBalanceTransactionTypeenumfeerefund.goObjectfieldloginlink.goObjectfieldproduct.goObjectandDeletedfieldterminal_location.goCorrected(postponing this until the major)*AccountAddressParamsreference in resource, should have been*AccountAddress. https://github.com/stripe/stripe-go/pull/1264/files#diff-1cec9d2aed3b04955c7fb6b3e5c43d9146271bbbf65e010fc5cf63e331210902R24 (is this a breaking bugfix? I don't think so because this didn't havejson:form annotations, so anybody trying to read this would already be broken)usagerecord.goObjectfield