codegen: balancetransaction.go #1287
Conversation
| ID string `json:"id"` | ||
| IssuingAuthorization *IssuingAuthorization `json:"-"` | ||
| IssuingDispute *IssuingDispute `json:"-"` | ||
| IssuingTransaction *IssuingAuthorization `json:"-"` |
There was a problem hiding this comment.
Bug to fix on next major.
| BalanceTransactionSourceTypeIssuingTransaction BalanceTransactionSourceType = "issuing.transaction" | ||
| BalanceTransactionSourceTypePayout BalanceTransactionSourceType = "payout" | ||
| BalanceTransactionSourceTypeRefund BalanceTransactionSourceType = "refund" | ||
| BalanceTransactionSourceTypeReversal BalanceTransactionSourceType = "reversal" |
There was a problem hiding this comment.
I wonder if it's an API version thingy I missed at some point
|
@richardm-stripe While the 4 new API resources make sense/exist, I think they are quite "special" and they are not in other client libraries (that I know of). Should we just suppress them for now. Those are pretty obscure edge-cases on |
| BalanceTransactionSourceTypeIssuingTransaction BalanceTransactionSourceType = "issuing.transaction" | ||
| BalanceTransactionSourceTypePayout BalanceTransactionSourceType = "payout" | ||
| BalanceTransactionSourceTypeRefund BalanceTransactionSourceType = "refund" | ||
| BalanceTransactionSourceTypeReversal BalanceTransactionSourceType = "reversal" |
There was a problem hiding this comment.
To fix on next major, should be transfer_reversal.
richardm-stripe
changed the title
|
@remi-stripe |
richardm-stripe
force-pushed
the
richardm-balancetransaction
branch
from
bbd7580
to
20e41ec
Compare
richardm-stripe
force-pushed
the
richardm-balancetransaction
branch
from
20e41ec
to
e92abe5
Compare
r? @stripe/api-library-reviewers
cc @stripe/api-libraries
Changelog
BalanceTransactionTypeenum:advance,advance_funding,refund_failure,reserve_transaction,reserved_funds,stripe_fx_fee,tax_fee,topup,topup_reversal,transfer_cancel,transfer_failure.BalanceTransactionSource:ConnectCollectionTransfer,FeeRefund,PlatformTaxFee,ReserveTransaction,TaxDeductedAtSource,TopupNote: codegen revealed two discrepancies
reversalvs.transfer_reversalandIssuingAuthorizationvsIssuingTransactionthat I am preserving with overrides that will be removed on the next major.