Fix all Get methods to support Params and remove deprecated ones #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure how I missed this one but since it's a major version, let's fix.
* Marking a charge as safe or fraudulent should be done via an Update * Updating or closing a dispute should be done through the dispute package
|
Haha, screaming fast time from issue to PR as usual! Thanks. LGTM. |
|
Released as 35.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IssuerFraudRecordListParamsnow uses*stringforChargeevent.Get()now takesEventParamsinstead ofParamsto be consistentGetmethod forcountryspec,exchangerate,issuerfraudrecordnow take an extra parameter to be consistent and allow setting the connected account.charge. MarkFraudulent()andcharge. MarkSafe()have been removed. You should usecharge.Update()insteadcharge.CloseDispute()andcharge.UpdateDispute()have been removed. You should usedispute.Update()ordispute.Close()instead.loginlinknow properly passes theparamsThis fixes #588
r? @brandur-stripe
cc @stripe/api-libraries