Add support for Reporting resources #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
commented
Sep 5, 2018
| } | ||
|
|
||
| // ReportRun is the resource representing a report run. | ||
| type ReportRun struct { |
There was a problem hiding this comment.
I decided not to prefix everything with Reporting in this case because it felt redundant and unlikely we'd have a conflict in the future.
Let me know if you think it's cleaner to keep the prefix though like we do for Issuing
There was a problem hiding this comment.
Yeah, makes sense in this situation.
|
LGTM! |
|
Released as 48.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries @brahn-stripe