Add support for the Review resource #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
review.go
Outdated
| Livemode bool `json:"livemode"` | ||
| Open bool `json:"open"` | ||
| Reason ReviewReasonType `json:"reason"` | ||
| Review *Review `json:"review"` |
There was a problem hiding this comment.
I think this is supposed to be Charge/*Charge/json:"charge" right?
There was a problem hiding this comment.
Damn nice catch, I messed up my string replace
| } | ||
|
|
||
| // Approve approves a review. | ||
| func (c Client) Approve(id string, params *stripe.ReviewApproveParams) (*stripe.Review, error) { |
There was a problem hiding this comment.
Thanks for following convention with the empty params struct here! It feels a little funny to do, but I like that we're staying consistent.
There was a problem hiding this comment.
yeah and I do feel like we'll have params soon!
|
Minor comment, but LGTM. ptal @remi-stripe |
remi-stripe
force-pushed
the
remi-add-radar-review
branch
from
b97de22
to
f888898
Compare
|
@brandur-stripe PTAL |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries