Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Credit card scanner should scan expiration date and not only "pan" #2484

Closed
alessiolapenna opened this issue Apr 18, 2023 · 4 comments · Fixed by #3539
Closed

[Feature] Credit card scanner should scan expiration date and not only "pan" #2484

alessiolapenna opened this issue Apr 18, 2023 · 4 comments · Fixed by #3539
Labels
CardScan kind:improvement triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@alessiolapenna
Copy link

Is your feature request related to a problem? Please describe.

When using the credit card scan without the payment sheet, the resulting object returns only the credit card "pan" and not the expiration date.

Describe the solution you'd like

Make the expiration date available in the returning data.

Describe alternatives you've considered

Using a different card scanner library
@yuki-stripe
Copy link
Collaborator

Hello @alessiolapenna, thanks for writing in! The card scan feature in PaymentSheet does attempt to read the expiration date, but can fail. I've added improving this to our list of feature requests.

@yuki-stripe yuki-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Apr 28, 2023
@jksk
Copy link

jksk commented Sep 27, 2023

Any ETA on this? We're also using CardScanSheet without PaymentSheet.

@via-guy
Copy link

via-guy commented Feb 28, 2024

+1

@via-guy via-guy mentioned this issue Feb 28, 2024
Open
via-guy added a commit to via-guy/stripe-ios that referenced this issue Mar 1, 2024
@via-guy
Makes the scanned name and expiry date of a card publicly visible
9dae684 
Fixes stripe#2875 and stripe#2484
@via-guy via-guy mentioned this issue Mar 1, 2024
Closed
@sgrant-stripe sgrant-stripe mentioned this issue Apr 25, 2024
Merged
sgrant-stripe added a commit that referenced this issue Apr 26, 2024
@sgrant-stripe
Makes the scanned name and expiry date of a card publicly visible (#3539
b0b8966 
)

## Summary
Remove `@_spi` for `ScannedCard` properties.
Fixes #2484 and #2875

## Motivation
In order to autofill our card entry form we need the scanned details,
but for some reason they're blocked from being publicly visible.

## Testing
N/A

## Changelog
[Changed] `ScannedCard` to allow access for `expiryMonth`, `expiryYear`
and `name`.
@davidme-stripe
Copy link
Contributor

This was fixed in recent versions of PaymentSheet: The expiration date scanning performance was subpar on newer devices, but it should be working consistently now. Let us know if you notice any other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CardScan kind:improvement triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Milestone
No milestone
6 participants
@jksk @alessiolapenna @yuki-stripe @davidme-stripe @via-guy @sfriedman-stripe