Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validationStateForCVC: "123" marked as valid for Amex #273

Closed
andresgarza opened this issue Nov 21, 2015 · 1 comment
Closed

validationStateForCVC: "123" marked as valid for Amex #273

andresgarza opened this issue Nov 21, 2015 · 1 comment

Comments

@andresgarza
Copy link

Despite the documentation saying that validationStateForCVC should return "STPCardValidationStateIncomplete for @"123" and STPCardBrandAmericanExpress" it returns a valid state

STPCardValidator.validationStateForCVC("123", cardBrand: STPCardBrand.Amex) //-> .Valid
@jflinter
Copy link

Ah yes, we recently changed that because amex sometimes actually does issue 3-digit CVCs. I've updated the documentation to reflect this change. Thanks!

davidme-stripe pushed a commit that referenced this issue Jul 7, 2021
@mludowise-stripe
MOBILESDK-318: Add StripeCore dependency to Stripe (#273)
45ee1ac 
- Add a dependency on `StripeCore` for the StripeiOS target, Carthage, SPM, and Cocoapods
- Update `StripeCore.podspec` to use a tag instead of a branch
- Shared `StripeCore.xcscheme` so Carthage builds StripeCore
- Modified `build_documentation.sh` to pass a temporary local podspec repo so it can find `StripeCore`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andresgarza @jflinter