Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STPPaymentCardTextField.valid is "true" on 3digit CVC's with AMEX -> But should be 4digits #299

Closed
richardhoehn opened this issue Jan 27, 2016 · 1 comment

Comments

@richardhoehn
Copy link

Hi All,

Great stuff!
I found a minor issue (I think) on the STPPaymentCardTextField. It has a "valid" flag that is set true when the user enters the card number, expiration date, and cvc. It seems like when you enter an AMEX card it goes true on 3digits of the CVC, however AMEX have 4digits. Initially I had my view close the "number" keypad once the STPPaymentCardTextField.valid was true and inadvertently gave users the impression it was ok.

I think the STPPaymentCardTextField control knows what card type it is and could then be cognisant of the 4digits on the AMEX cards?

Thanks

@jflinter
Copy link

Hey there - this stems from the little-known fact that some amex cards do in fact have 3-digit CVCs, so we'd rather err on the side of accepting them. Thanks for bringing this up though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants