Don't enable the "save this card" checkbox by default #3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidme-stripe
requested review from
kgaidis-stripe,
a team and
wooj-stripe
and removed request for
kgaidis-stripe and
a team
wooj-stripe
reviewed
Jun 5, 2024
Comment on lines
2642
to
2644
| XCTAssertFalse(saveThisCardToggle.isSelected) | ||
| saveThisCardToggle.tap() | ||
|
|
There was a problem hiding this comment.
Nit: seems like we should add (for multiple of these)
saveThisCardToggle.tap()
+ XCTAssertTrue(saveThisCardToggle.isSelected)
There was a problem hiding this comment.
I think the test enforces this (it checks if the card is saved!) but I can
Comment on lines
63
to
+64
| case .automatic: | ||
| // only enable the save checkbox by default for US | ||
| return Locale.current.stp_regionCode == "US" | ||
| return false |
There was a problem hiding this comment.
We should probably add this to our list of "things to break" in the next major version
There was a problem hiding this comment.
I like having .automatic around just in case, maybe someday we can control it server-side
wooj-stripe
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change the "save this card" checkbox to be unchecked by default.
Motivation
Latest guidance.
Testing
CI, updated existing tests.
Changelog
Added a changelog entry.