Expose billing details & PMT for FlowController #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooj-stripe
force-pushed
the
wooj/pmoData
branch
from
de10c65
to
0e5b6f5
Compare
wooj-stripe
requested review from
davidme-stripe and
yuki-stripe
and removed request for
davidme-stripe
yuki-stripe
reviewed
Jan 11, 2024
StripePaymentSheet/StripePaymentSheetTests/PaymentSheet/PaymentSheetConfigurationTests.swift
Outdated
Show resolved
Hide resolved
StripePaymentSheet/StripePaymentSheetTests/PaymentSheet/PaymentSheetConfigurationTests.swift
Show resolved
Hide resolved
StripePaymentSheet/StripePaymentSheetTests/PaymentSheet/PaymentSheetConfigurationTests.swift
Outdated
Show resolved
Hide resolved
StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/PaymentSheetFlowController.swift
Outdated
Show resolved
Hide resolved
StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/PaymentSheetFlowController.swift
Outdated
Show resolved
Hide resolved
Example/PaymentSheet Example/PaymentSheet Example/PaymentSheetTestPlayground.swift
Outdated
Show resolved
Hide resolved
…tSheetConfigurationTests.swift Co-authored-by: Yuki <yuki@stripe.com>
…tSheetConfigurationTests.swift Co-authored-by: Yuki <yuki@stripe.com>
…entSheetFlowController.swift Co-authored-by: Yuki <yuki@stripe.com>
…entSheetFlowController.swift Co-authored-by: Yuki <yuki@stripe.com>
yuki-stripe
previously approved these changes
Jan 12, 2024
StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/PaymentSheetConfiguration.swift
Outdated
Show resolved
Hide resolved
StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/PaymentSheetConfiguration.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Yuki <yuki@stripe.com>
…entSheetConfiguration.swift Co-authored-by: Yuki <yuki@stripe.com>
…entSheetConfiguration.swift Co-authored-by: Yuki <yuki@stripe.com>
yuki-stripe
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Expose billing details & PMT for FlowController
Motivation
BillingDetails typed in by customers, and payment method type, should be available immediately when flowcontroller payment method selector sheet is dismissed
Testing
Added ui test
Updated playground and did manual tests
Changelog