Fix delete behavior in customerSheet #3309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix delete behavior in CustomerSheet
Motivation
If an exception is thrown in detachPaymentMethod(), we are incorrectly removing the paymentMethod in the UI. Instead, we should attempt to remove it, and if successful, then update the UI
Testing
Manually by adding PaymentSheetError.unknown("--"), in detachPaymentMethod
Manually w/ the success case
Relying on automated UI tests
Changelog