Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable availability warnings. #823

Merged
merged 1 commit into from Nov 2, 2017

Conversation

bdorfman-stripe
Copy link
Contributor

This warning only knows about the new @available objc language feature (that matches the Swift one). All the cases it catches are already blocked by other methods, like selector testing, so it's not actually a problem. We can't add @available calls until we drop Xcode 8 support so disabling temporarily seems the best solution.

This warning only knows about the new `@available` objc language feature (that matches the Swift one). All the cases it catches are already blocked by other methods, like selector testing, so it's not actually a problem. We can't add `@available` calls until we drop Xcode 8 support so disabling temporarily seems the best solution.
@@ -1,6 +1,7 @@
use_frameworks!

target 'CocoapodsTest' do
platform :ios, '8.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I noticed our cocoapods test was throwing warnings because we didn't have this specified. Probably need to add it to the without_frameworks version also. I have a task on me to change a bunch of this stuff when we drop Xcode 8 / iOS 8 so I'll do it then.

Copy link
Contributor

@bg-stripe bg-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, lgtm!

@bdorfman-stripe bdorfman-stripe merged commit 31ff02d into master Nov 2, 2017
@bdorfman-stripe bdorfman-stripe mentioned this pull request Nov 2, 2017
@bdorfman-stripe bdorfman-stripe deleted the bdorfman-silence-availability-warnings branch November 2, 2017 21:41
@danj-stripe danj-stripe mentioned this pull request Nov 9, 2017
10 tasks
davidme-stripe pushed a commit that referenced this pull request Mar 7, 2022
* Remember OTP prompt decline

* Cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants