Fix STPPaymentCardTextField touch handling bugs for small devices on iOS 11
#883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This view controls what part of the text field is visible, and so we need to be able to tap the text field behind it when it exists (happens on 4" devices) In iOS 11, this view appears in the view hierarchy (seen in Xcode Visual Debugger), and it's capturing touches. Tapping/clicking directly on the card numbers does not cause the numbers text field to become first responder, instead it dismisses first responder! This change fixes that, and now you can go back to the numbers field from the month field.
…the numbers field. Especially on 4" devices (in compact mode), there's a very small touch target for activating the numbers field. The brand image is just as big, but taps on it will resign first responder. I considered doing something even more complicated: ideally any touch in the whole STPPaymentCardTextField's bounds would give it first responder, and it would be the text field that's closest to where the user tapped. For this quick change, I don't really want to adjust the subfield bounds, or change/understand the code that calculates the frames to increase their effective touch targets. Just making the brandImage tappable is a quick and easy win.
|
In the debugger view, you can see the frames of the fields:
|
danj-stripe
deleted the
danj/bugfix/paymentcardtextfield-touch-handling
branch
mludowise-stripe
pushed a commit
that referenced
this pull request
Mar 24, 2022
* Add `titleAttributes` to `Button` * Remove redundant icon view Prevent extra leading and trailing padding from being added to the button. * Update snapshots * Hide image view if needed * Reduce the number of constraints * Simplify layout logic * Update plain button insets * Adjust insets * Invalidate intrinsic content size when needed * Prevent unnecessary constraint updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
maskViewoverSTPPaymentCardTextFieldnumbers no longer blocks touches on iOS 11.Also, making the
brandImagetappable to move focus/first responder to the numbers textfield.
Motivation
Found while testing #870, #855, etc. Filed as IOS-601
Testing
Manual testing in Standard Integration sample app, on small & large phones.