Remove Bitcoin source support #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeydong-stripe
force-pushed
the
joeydong/removeBitcoin
branch
6 times, most recently
from
239999d
to
1443eff
Compare
joeydong-stripe
changed the title
joeydong-stripe
force-pushed
the
joeydong/removeBitcoin
branch
from
1443eff
to
6eaf8bf
Compare
joeydong-stripe
force-pushed
the
joeydong/removeBitcoin
branch
3 times, most recently
from
51bac3d
to
702fee0
Compare
joeydong-stripe
force-pushed
the
joeydong/removeBitcoin
branch
from
702fee0
to
e53d570
Compare
danj-stripe
approved these changes
Apr 26, 2018
| @@ -1,3 +1,4 @@ | |||
| // Source: https://stripe.com/docs/sources/ideal | |||
There was a problem hiding this comment.
AFAIK comments are illegal in JSON, so I think this should be removed
There was a problem hiding this comment.
😉 I added this feature a long time ago to the STPTestUtils: e27d40d#diff-048bbc1b680ccc6bc67023bfe39032b4R44
This procedure does still break if comments are inline with JSON. Also seems like STPTestUtils and STPFixtures should be combined eventually.
danj-stripe
added a commit
that referenced
this pull request
Jul 6, 2018
danj-stripe
added a commit
that referenced
this pull request
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createBitcoinParams. Please use a different payment method.