Better log the error causing the JSON parsing to fail on deserialization #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-improve-error-logging
branch
from
26baf7d
to
ae0f73d
Compare
|
Pushed a brand new version based on @ob-stripe's work just adding an extra details in the default log line so that we can debug this more easily. He also helped write an explicit test for this |
|
Note that |
richardm-stripe
approved these changes
Nov 24, 2020
There was a problem hiding this comment.
This looks good to me.
I took the liberty of moving the test per @ob's comment in the latest commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're now logging the error message associated with the
JsonSyntaxExceptionexception raised on parsing, if any. We also record that exception as the cause of theApiExceptionwe throw.r? @richardm-stripe
cc @stripe/api-libraries