Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Java 14 and 15 #1251

Merged
merged 2 commits into from Sep 8, 2021
Merged

Test Java 14 and 15 #1251

merged 2 commits into from Sep 8, 2021

Conversation

ob-stripe
Copy link
Contributor

@ob-stripe ob-stripe commented Aug 30, 2021

r? @stripe/api-library-reviewers
cc @stripe/api-libraries

Test Java 14 and 15, and bump all dependencies.

Note that Java 16 is out, and Java 17 will be out soonish. However these versions require Gradle 7, and upgrading to Gradle 7 will necessitate rewriting deploy.gradle to use the maven-publish plugin instead of maven (cf. https://docs.gradle.org/6.9.1/userguide/upgrading_version_5.html#legacy_publication_system_is_deprecated_and_replaced_with_the_publish_plugins). This is a non-trivial change that will be somewhat annoying to test, so I'm leaving it to the client libraries team 馃槢

Copy link

@seang-stripe seang-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stripe-ci stripe-ci assigned ob-stripe and unassigned seang-stripe Sep 8, 2021
@ob-stripe ob-stripe merged commit c50c10f into master Sep 8, 2021
@ob-stripe ob-stripe deleted the ob-new-java branch September 8, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants