Upgrade Gradle #1261
Merged
Upgrade Gradle #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @richardm-stripe
cc @stripe/api-libraries
enabledwithrequired: https://docs.gradle.org/7.2/dsl/org.gradle.api.reporting.Report.html#org.gradle.api.reporting.Report:enabledconfigvalues fromlombokblock. There is little context in the PR that deprecatesconfigbut it looks like the plugin no longer generates thelombok.configfile and users are supposed to commit the file directly (which we were already doing anyway).Unfortunately we cannot yet test Java 16+ because google-java-format requires special configuration with Java 16: https://github.com/google/google-java-format#jdk-16. That configuration can be set in gradle via the
org.gradle.jvmargsparameter ingradle.properties, but of course that fails with Java 1.8... We need a way to conditionally set the parameter depending on Java version and I couldn't find one in 5 minutes of googling.