API Updates #1315
Merged
API Updates #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
commented
Feb 25, 2022
| @Getter | ||
| @Setter | ||
| @EqualsAndHashCode(callSuper = false) | ||
| public static class NextActionKonbiniDisplayDetailsStores extends StripeObject { |
There was a problem hiding this comment.
This is almost certainly not what we want. Should be just public static class Stores and be an inner class of NextActionKonbiniDisplayDetails
richardm-stripe
commented
Feb 25, 2022
| @Getter | ||
| @Setter | ||
| @EqualsAndHashCode(callSuper = false) | ||
| public static class NextActionKonbiniDisplayDetailsStoresStore extends StripeObject { |
There was a problem hiding this comment.
This should also be an inner class.
To be really consistent, each of these would be separate classes, too...
richardm-stripe
commented
Feb 25, 2022
| * created by the subscription. | ||
| */ | ||
| @SerializedName("konbini") | ||
| Invoice.PaymentMethodOptions.Konbini konbini; |
There was a problem hiding this comment.
We're going to have to unshare this.
richardm-stripe
commented
Feb 26, 2022
| @Getter | ||
| @Setter | ||
| @EqualsAndHashCode(callSuper = false) | ||
| public class SetupIntentTypeSpecificPaymentMethodOptionsClient extends StripeObject {} |
There was a problem hiding this comment.
Oof this should not be generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codegen for openapi 3c477c0.
r? @richardm-stripe
cc @stripe/api-libraries
Changelog
konbini_paymentsonAccountUpdateParams.capabilities,AccountCreateParams.capabilities, andAccount.capabilitieskonbinionCharge.payment_method_details,CheckoutSessionCreateParams.payment_method_options,Checkout.Session.payment_method_options,InvoiceCreateParams.payment_settings.payment_method_options,InvoiceUpdateParams.payment_settings.payment_method_options,Invoice.payment_settings.payment_method_options,PaymentIntentCreateParams.payment_method_data,PaymentIntentCreateParams.payment_method_options,PaymentIntentUpdateParams.payment_method_data,PaymentIntentUpdateParams.payment_method_options,PaymentIntentConfirmParams.payment_method_data,PaymentIntentConfirmParams.payment_method_options,PaymentIntent.payment_method_options,PaymentMethodCreateParams,PaymentMethod,SubscriptionCreateParams.payment_settings.payment_method_options,SubscriptionUpdateParams.payment_settings.payment_method_options, andSubscription.payment_settings.payment_method_optionskonbinion enumsCheckoutSessionCreateParams.payment_method_types[]andPaymentMethodCreateParams.typekonbinion enumsCustomerListPaymentMethodsParams.typeandPaymentMethodListParams.typekonbinion enumsInvoiceCreateParams.payment_settings.payment_method_types[],InvoiceUpdateParams.payment_settings.payment_method_types[],SubscriptionCreateParams.payment_settings.payment_method_types[], andSubscriptionUpdateParams.payment_settings.payment_method_types[]konbinion enumsPaymentIntentCreateParams.payment_method_data.type,PaymentIntentUpdateParams.payment_method_data.type, andPaymentIntentConfirmParams.payment_method_data.typekonbini_display_detailsonPaymentIntent.next_action