Expose response objects #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
suggested changes
Nov 9, 2017
|
Left a few comments, but lgtm overall! Thanks for tackling this :) |
ob-stripe
reviewed
Nov 9, 2017
ob-stripe
reviewed
Nov 10, 2017
ob-stripe
reviewed
Nov 10, 2017
ob-stripe
approved these changes
Nov 10, 2017
|
@ob-stripe Should I squash my commits? |
ob-stripe
reviewed
Nov 10, 2017
|
This is starting to look great! @brandur-stripe Mind taking a look too? |
We don't have a firm policy on this, but that's what I usually do. |
sedouard
commented
Nov 10, 2017
sedouard
force-pushed
the
success-response-headers
branch
3 times, most recently
from
6429389
to
715c40b
Compare
|
@ob-stripe per stripe/stripe-python#371 I've removed the optional flag for including responses and changed the field for responses to |
sedouard
force-pushed
the
success-response-headers
branch
from
715c40b
to
030d934
Compare
ob-stripe
reviewed
Nov 16, 2017
|
@ob-stripe thanks! Made all the requested changes. |
sedouard
force-pushed
the
success-response-headers
branch
from
da4197d
to
3c488ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is addressing #420 to provide access to not only response headers but general data on underlying HTTP requests made by API request to consumers.
Based on some of the discussion on the issue, I'm proposing adding response data to StripeObject and changing the interface of StripeResponse (and adding
StripeHeadersclass) to be a bit closer to the popular OkHTTP's response class.@ob-stripe what are your thoughts around this? Once we settle down on what looks best I'll go ahead and include unit tests.