Better handling of namespaced resources #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
force-pushed
the
ob-namespaced-resources
branch
from
2ead9f1
to
2aec858
Compare
|
LGTM though I wonder if that will break at some point to rely on that 4 levels. Again I prefer to not approve core changes so re-assigning to @mickjermsurawong-stripe |
|
Left a nit comment, but I don't feel too strongly about; I doubt we will have subpackage within current package. |
ob-stripe
force-pushed
the
ob-namespaced-resources
branch
from
2aec858
to
c884f9c
Compare
|
Released as 7.18.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @remi-stripe
cc @stripe/api-libraries
Better handling of namespaced resources, by using the sub-package's name as the namespace (e.g. if the sub-package is
com.stripe.model.issuing,issuingis the resource's namespace).This way we don't have to manually add new namespaces.
This is still a bit too implicit / magic for my taste and I'd rather we explicitly declare the full Stripe object name in each model class, but we can do that later.