New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to the Payment Intent APIs for the next API version #670
Conversation
|
@mickjermsurawong-stripe thanks a lot for the review, this definitely helps vet the approach! |
b5eb2bc
to
07ab3a5
Compare
@mickjermsurawong-stripe API version is going out tomorrow so marking this as ready to merge now that stripe-mock is updated and assigning to you for a full review. |
@EqualsAndHashCode(callSuper = false) | ||
public static class NextAction extends StripeObject { | ||
NextActionRedirectToUrl redirectToUrl; | ||
String type; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need the additional field? At least it shows up in my autogen PR https://github.com/stripe/stripe-java/pull/676/files.. Also confirm that it's present in public OpenAPI
Map<String, Object> useStripeSdk;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mickjermsurawong-stripe This is undocumented/secret right now though so not something we'd want to ship for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed, we want the parameter/enum value but this property should not be in the libraries since it's opaque and specific to stripe.js
ptal @remi-stripe, maybe we are missing a field on |
ah good to know.. Will make a PR to undocument that in pay-server. |
We are going to ship some changes to the Payment Intent APIs in the next API version. Though are fairly self-contained and pave the way for future changes. Changes are:
status
: removerequire_source
andrequire_source_action
and addrequires_payment_method
andrequires_action
next_source_action
renamed tonext_action
allowed_source_types
renamed topayment_method_types
authorize_with_url
renamed toredirect_to_url
both in the type of next action and in the hash that describes that next action.cc @stripe/api-libraries @danwang-stripe
cc @mickjermsurawong-stripe To confirm naming for the new classes make sense (now that they are inline)