Add support for expanding latest_invoice on `Subscription
#684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flagging tests will fail while we wait on the new stripe-mock, which is itself blocked on releasing openapi. |
|
@remi-stripe latest invoice looks good. Pre-approving this because I know you tested stripe-mock with subscription expandable latest invoice earlier. Do you want me to take stripe-mock release? |
|
I got the release (but I'll ask you for review as usual). Thanks for the quick review. I'll re-run the test once stripe-mock is released to be sure. |
Also fixed a test that is now failing as `destination` on Charge is now undocumented and not in openapi anymore
remi-stripe
force-pushed
the
remi-add-latest-invoice
branch
from
b353e86
to
19cb3d5
Compare
|
rebased on latest master, approving. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for expanding
latest_invoiceonSubscription. This also fixed a test that is now failing asdestination` on Charge is now undocumented and not in openapi anymorer? @mickjermsurawong-stripe
cc @stripe/api-libraries