Replace Cobertura with JaCoCo #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur-stripe
approved these changes
Nov 8, 2019
There was a problem hiding this comment.
Wow, if they don't have lambda support by now, they may never have it. LGTM.
OOC: Given how definitive the previous failure was, I'm surprised that the build didn't exit with a bad status code and let us know. Do you know if that was a Cobertura-specific thing? Does Jacoco fix that problem?
|
My guess is that the Cobertura plugin crashed in a way that didn't cause Gradle to stop the execution, and a partial report was still produced and uploaded to coveralls.io by the Coveralls plugin. I'm not sure though -- it's definitely surprising that Gradle didn't stop and return an error. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
So I just noticed that our coverage reports have been broken for months, because we're using a lambda expression (here) and Cobertura doesn't support them (see cobertura/cobertura#274).
Given that the issue is 4 years old and still not fixed, I've followed the advice of someone in the thread and migrated from Cobertura to JaCoCo, another code coverage tool.
(Our coverage numbers are still fairly abysmal because ~nothing in
com.stripe.paramis tested, but that's a different story.)