Merge pull request #474 from stripe/zwick_partner_id_set_app_info

Adds support for an optional 'partner_id' parameter in 'setAppInfo'
stripe · Nov 12, 2018 · 172e076 · 172e076
2 parents ed076a2 + 65de867
commit 172e076
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/stripe.js b/lib/stripe.js
@@ -21,7 +21,7 @@ Stripe.USER_AGENT = {
 
 Stripe.USER_AGENT_SERIALIZED = null;
 
-var APP_INFO_PROPERTIES = ['name', 'version', 'url'];
+var APP_INFO_PROPERTIES = ['name', 'version', 'url', 'partner_id'];
 
 var EventEmitter = require('events').EventEmitter;
 var exec = require('child_process').exec;

diff --git a/test/stripe.spec.js b/test/stripe.spec.js
@@ -96,7 +96,7 @@ describe('Stripe Module', function() {
     });
 
     describe('when given at least a `name`', function() {
-      it('should set name, version and url of stripe._appInfo', function() {
+      it('should set name, partner ID, url, and version of stripe._appInfo', function() {
         stripe.setAppInfo({
           name: 'MyAwesomeApp',
         });
@@ -121,17 +121,29 @@ describe('Stripe Module', function() {
           name: 'MyAwesomeApp',
           url: 'https://myawesomeapp.info',
         });
+
+        stripe.setAppInfo({
+          name: 'MyAwesomeApp',
+          partner_id: 'partner_1234',
+        });
+        expect(stripe._appInfo).to.eql({
+          name: 'MyAwesomeApp',
+          partner_id: 'partner_1234',
+        });
+
       });
 
       it('should ignore any invalid properties', function() {
         stripe.setAppInfo({
           name: 'MyAwesomeApp',
+          partner_id: 'partner_1234',
           version: '1.2.345',
           url: 'https://myawesomeapp.info',
           countOfRadishes: 512,
         });
         expect(stripe._appInfo).to.eql({
           name: 'MyAwesomeApp',
+          partner_id: 'partner_1234',
           version: '1.2.345',
           url: 'https://myawesomeapp.info',
         });