Add Node 19 testing

stripe · Jan 12, 2023 · 2156917 · 2156917
1 parent a91857a
commit 2156917
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -65,6 +65,7 @@ jobs:
         os:
           - "ubuntu-latest"
         node:
+          - "19"
           - "18"
           - "16"
           - "14"

diff --git a/test/net/helpers.js b/test/net/helpers.js
@@ -166,7 +166,13 @@ const createHttpClientTestSuite = (createHttpClientFn, extraTestsFn) => {
             await response.toJSON();
             fail();
           } catch (e) {
-            expect(e.message).to.contain('Unexpected end of JSON input');
+            expect(e.message).to.satisfy(
+              (v) =>
+                // Node < 19
+                v.includes('Unexpected end of JSON input') ||
+                // Node >= 19
+                v.includes('Unterminated string in JSON at position 3')
+            );
           }
         });
       });