Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

previous_attributes on StripeEvent should be typed as Partial #1978

Closed
pakrym-stripe opened this issue Dec 21, 2023 · 2 comments
Closed

previous_attributes on StripeEvent should be typed as Partial #1978

pakrym-stripe opened this issue Dec 21, 2023 · 2 comments
Labels
feature-request

Comments

@pakrym-stripe
Copy link
Contributor

pakrym-stripe commented Dec 21, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

Created from #758 (comment)

@hayksaryan

For me, event.data.previous_attributes is still typed as Stripe.Event.Data.PreviousAttributes.
I would expect a generic that properly infers Partial from Stripe.SomethingUpdatedEvent.
Otherwise, I'm forced to do it like this: event.data.previous_attributes as Partial<Stripe.Subscription>
@pakrym-stripe pakrym-stripe mentioned this issue Dec 21, 2023
Closed
@pakrym-stripe
Copy link
Contributor Author

This is fixed in v14.13.0

@hayksaryan
Copy link

Thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hayksaryan @pakrym-stripe